[scponly] [Fwd: Bug#289861: Compile error with --disable-scp-compat]

[Thomas Wana]

FYI

Tom

-------- Original Message --------
Subject: Bug#289861: Compile error with --disable-scp-compat
Resent-Date: Tue, 11 Jan 2005 13:03:02 UTC
Resent-From: Mrten <debian at ii.nl>
Resent-To: debian-bugs-dist at lists.debian.org
Resent-CC: Thomas Wana <greuff at debian.org>
Date: Tue, 11 Jan 2005 13:57:01 +0100
From: Mrten <debian at ii.nl>
Reply-To: Mrten <debian at ii.nl>, 289861 at bugs.debian.org
To: submit at bugs.debian.org

Package: scponly
Version: 4.0-1
Severity: minor
Tags: upstream, patch

if one configures scponly with --disable-scp-compat, it fails to
compile with the following error:

# Add here commands to compile the package.
/usr/bin/make
make[1]: Entering directory `/home/root/scponly/scponly-4.0'
i386-linux-gcc -Wall -g -O2 -I. -I. -DHAVE_CONFIG_H 
-DDEBUGFILE='"/usr/../etc/scponly/debuglevel"' -o scponly.o -c scponly.c
scponly.c:70: warning: missing braces around initializer
scponly.c:70: warning: (near initialization for `commands[2]')
scponly.c:79: error: `PROG_SCP' undeclared here (not in a function)
scponly.c:79: error: initializer element is not constant
scponly.c:79: error: (near initialization for `dangerous_args[0].name')
scponly.c:79: error: initializer element is not constant
scponly.c:79: error: (near initialization for `dangerous_args[0]')
scponly.c:80: error: initializer element is not constant
scponly.c:80: error: (near initialization for `dangerous_args[1]')
scponly.c:87: error: initializer element is not constant
scponly.c:87: error: (near initialization for `dangerous_args[2]')
scponly.c:90: warning: missing braces around initializer
scponly.c:90: warning: (near initialization for `dangerous_args[3]')
scponly.c:90: error: initializer element is not constant
scponly.c:90: error: (near initialization for `dangerous_args[3]')
scponly.c: In function `main':
scponly.c:219: warning: char format, different type arg (arg 3)
scponly.c: In function `process_ssh_request':
scponly.c:380: warning: unused variable `tmpstring'
scponly.c:381: warning: unused variable `bad_winscp3str'
scponly.c:383: warning: unused variable `reqlen'
scponly.c:384: warning: unused variable `env'
make[1]: *** [scponly.o] Error 1
make[1]: Leaving directory `/home/root/scponly/scponly-4.0'
make: *** [build-stamp] Error 2


the simple patch is to edit scponly.c and edit around line 77

cmd_arg_t dangerous_args[] =
{
         { PROG_SCP, "-S" },
         { PROG_SFTP_SERVER, "-S" },
#ifdef UNISON_COMPAT

to

cmd_arg_t dangerous_args[] =
{
#ifdef ENABLE_SCP2
         { PROG_SCP, "-S" },
#endif
         { PROG_SFTP_SERVER, "-S" },
#ifdef UNISON_COMPAT

Mrten.
-- 
A: No.
Q: Should I include quotations after my reply?