[scponly] --enable-passwd-compat

[Hideyuki KURASHINA]

Hi, Kaleb,

Personaly, I do not have a need to specify --enable-passwd-compat,
however,

>>> On Fri, 18 Mar 2005 16:13:08 -0800, Kaleb Pederson <kpederson at ewu.edu> said:

> Either way, config.h looks as follows 
> with password compat mode on:
> 
> ...
> /* passwd compatibility */
> #ifdef ENABLE_PASSWD
> #define PROG_PASSWD "/bin/passwd"
> #endif
> 
> But in scponly.c it's looking for PASSWD_COMPAT.
> 
> #ifdef PASSWD_COMPAT
>     { PROG_PASSWD, 1 },
> #endif /*ENABLE_PASSWD*/
> 
> Obviously, the above should reference ENABLE_PASSWD or PASSWD_COMPAT needs to 
> be defined...

I think ENABLE_PASSWD in config.h.in should be changed to PASSWD_COMPAT
with considering other compatibilities (rsync, unison and etc).

Joe, as Kaleb pointed out, could you please include following patch?

- - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
--- config.h.in.orig	Mon Nov 29 05:27:52 2004
+++ config.h.in	Tue Mar 22 21:20:37 2005
@@ -66,7 +66,7 @@
 #endif
 
 /* passwd compatibility */
-#ifdef ENABLE_PASSWD
+#ifdef PASSWD_COMPAT
 #undef PROG_PASSWD
 #endif

- - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -

I also found that changing comment strings in scponly.c would help
to avoid confusion.

- - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
--- scponly.c.orig	Sun Nov 28 10:16:39 2004
+++ scponly.c	Tue Mar 22 21:23:31 2005
@@ -52,19 +52,19 @@
 
 #ifdef UNISON_COMPAT
 	{ PROG_UNISON, 1 },
-#endif /*ENABLE_UNISON*/
+#endif /*UNISON_COMPAT*/
 
 #ifdef RSYNC_COMPAT
 	{ PROG_RSYNC, 1 },
-#endif /*ENABLE_RSYNC*/
+#endif /*RSYNC_COMPAT*/
 
 #ifdef PASSWD_COMPAT
 	{ PROG_PASSWD, 1 },
-#endif /*ENABLE_PASSWD*/
+#endif /*PASSWD_COMPAT*/
 
 #ifdef SVN_COMPAT
 	{ PROG_SVN, 1 },
-#endif /*ENABLE_SVN*/
+#endif /*SVN_COMPAT*/
 
 	NULL
 };
- - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -

-- rushani