[scponly] scponly 3.11 various bug fixes - patch released.

[wby oblyr]

thanks for this patch, david, i will incorporate your patch with a careful eye and release scponly 
3.12 shortly.

also note that the UNISON bugs have been reported by numerous people, and they too will be fixed in 
3.12

thanks all,
joe

David Ramsden wrote this message on Wed, May 26, 2004 at 09:06 +0100:
> On Wed, May 26, 2004 at 09:36:59AM +0200, Thomas Wana wrote:
> > Am Mittwoch, 26. Mai 2004 00:18 schrieb David Ramsden:
> > >
> > > [1] http://david.hexstream.eu.org/scponly-3.11-bugfixes.patch
> > ...
> > > snprintf(chng_dir, FILENAME_MAX, root_dir + 1, strlen(root_dir));
> > 
> > Just a note, don't use string constants as format strings.
> > While this is no format string bug here, this is the typical
> > source of format string bugs. Someone changes something
> > here in the future and *bang*.
> > 
> 
> Sorry. My bad. That was ment to look more like your line (below), with a
> format string in there!
> Thanks for finding that :-)
> 
> > Additionally, the strlen(root_dir) at the end is unneccessary.
> > 
> > Instead, use
> > 
> > snprintf(chng_dir, FILENAME_MAX, "%s", root_dir + 1);
> > 
> [snip]
> 
> I've updated my patch, just in case anyone wishes to use it!
> Much appreciated Tom. As I said, I'm not a great C programmer but I "get
> by" :)
> 
> If anyone has the time, maybe scponly should be run through `splint' to
> check for any programming errors. Just a thought.
> 
> Kind regards.
> David.
> -- 
>  .''`.     David Ramsden <david at hexstream.eu.org>
> : :'  :    http://david.hexstream.eu.org/
> `. `'`     PGP key ID: 507B379B on wwwkeys.pgp.net
>   `-  Debian - when you have better things to do than to fix a system.



> _______________________________________________
> scponly mailing list
> scponly at lists.ccs.neu.edu
> https://lists.ccs.neu.edu/bin/listinfo/scponly


-- 
----

PGP KEY: http://www.sublimation.org/contact.html
PGP Key fingerprint = EC4B 0DA5 B4F6 BDDD 9176 55D6 3A6A 7D63 158F 22D2